[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 24/47] block: introduce new dirty bitmap functio
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH 24/47] block: introduce new dirty bitmap functionality |
|
Date: |
Tue, 11 Sep 2012 16:57:03 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 |
Am 24.07.2012 13:04, schrieb Paolo Bonzini:
> Assert that write_compressed is never used with the dirty bitmap.
> Setting the bits early is wrong, because a coroutine might concurrently
> examine them and copy incomplete data from the source.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
Looks good, but I think it should be documented at least that
bdrv_get_next_dirty() hangs when it's called and there is no dirty block.
Kevin
- Re: [Qemu-devel] [PATCH 24/47] block: introduce new dirty bitmap functionality,
Kevin Wolf <=