qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/4] tcg/i386: Remove unused registers from tcg_


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 2/4] tcg/i386: Remove unused registers from tcg_target_call_iarg_regs
Date: Wed, 12 Sep 2012 22:18:42 +0100

On 12 September 2012 21:44, Stefan Weil <address@hidden> wrote:
> --- a/tcg/i386/tcg-target.c
> +++ b/tcg/i386/tcg-target.c
> @@ -75,9 +75,7 @@ static const int tcg_target_call_iarg_regs[] = {
>      TCG_REG_R8,
>      TCG_REG_R9,
>  #else
> -    TCG_REG_EAX,
> -    TCG_REG_EDX,
> -    TCG_REG_ECX
> +    /* 32 bit mode uses stack based calling convention (GCC default). */
>  #endif
>  };

This makes the array zero-length for 32 bit targets, but functions
like tcg_out_tlb_load() and tcg_out_qemu_ld() still unconditionally
access elements in it...

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]