[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 03/14] ehci: Fix interrupts stopping when Interrupt
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PATCH 03/14] ehci: Fix interrupts stopping when Interrupt Threshold Control is 8 |
Date: |
Thu, 13 Sep 2012 10:39:49 +0200 |
From: Hans de Goede <address@hidden>
If Interrupt Threshold Control is 8 or a multiple of 8, then
s->usbsts_frindex can become exactly 0x4000, at which point
(s->usbsts_frindex > s->frindex) will never become true, as
s->usbsts_frindex will not be lowered / reset in this case.
This patch fixes this.
Signed-off-by: Hans de Goede <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/usb/hcd-ehci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index f5ba8e1..54273d7 100644
--- a/hw/usb/hcd-ehci.c
+++ b/hw/usb/hcd-ehci.c
@@ -2413,7 +2413,7 @@ static void ehci_update_frindex(EHCIState *ehci, int
frames)
if (ehci->frindex == 0x00004000) {
ehci_raise_irq(ehci, USBSTS_FLR);
ehci->frindex = 0;
- if (ehci->usbsts_frindex > 0x00004000) {
+ if (ehci->usbsts_frindex >= 0x00004000) {
ehci->usbsts_frindex -= 0x00004000;
} else {
ehci->usbsts_frindex = 0;
--
1.7.1
- [Qemu-devel] [PULL 00/14] usb patch queue, Gerd Hoffmann, 2012/09/13
- [Qemu-devel] [PATCH 04/14] ehci: Don't process too much frames in 1 timer tick (v2), Gerd Hoffmann, 2012/09/13
- [Qemu-devel] [PATCH 07/14] ehci: Walk async schedule before and after migration, Gerd Hoffmann, 2012/09/13
- [Qemu-devel] [PATCH 03/14] ehci: Fix interrupts stopping when Interrupt Threshold Control is 8,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH 06/14] ehci: Don't set seen to 0 when removing unseen queue-heads, Gerd Hoffmann, 2012/09/13
- [Qemu-devel] [PATCH 09/14] usb-redir: Add an already_in_flight packet-id queue, Gerd Hoffmann, 2012/09/13
- [Qemu-devel] [PATCH 14/14] uhci: Don't queue up packets after one with the SPD flag set, Gerd Hoffmann, 2012/09/13
- [Qemu-devel] [PATCH 05/14] configure: usbredir fixes, Gerd Hoffmann, 2012/09/13
- [Qemu-devel] [PATCH 13/14] usb-redir: Revert usb-redir part of commit 93bfef4c, Gerd Hoffmann, 2012/09/13
- [Qemu-devel] [PATCH 10/14] usb-redir: Store max_packet_size in endp_data, Gerd Hoffmann, 2012/09/13
- [Qemu-devel] [PATCH 08/14] usb-redir: Change cancelled packet code into a generic packet-id queue, Gerd Hoffmann, 2012/09/13
- [Qemu-devel] [PATCH 01/14] usb-host: allow emulated (non-async) control requests without USBPacket, Gerd Hoffmann, 2012/09/13
- [Qemu-devel] [PATCH 12/14] usb-redir: Add chardev open / close debug logging, Gerd Hoffmann, 2012/09/13
- [Qemu-devel] [PATCH 02/14] ehci: switch to new-style memory ops, Gerd Hoffmann, 2012/09/13