[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 04/10] spice: send updates only for changed screen c
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PATCH 04/10] spice: send updates only for changed screen content |
Date: |
Thu, 13 Sep 2012 10:45:20 +0200 |
when creating screen updates go compare the current guest screen
against the mirror (which holds the most recent update sent), then
only create updates for the screen areas which did actually change.
[ v2: drop redundant qemu_spice_create_one_update call ]
Signed-off-by: Gerd Hoffmann <address@hidden>
---
ui/spice-display.c | 56 +++++++++++++++++++++++++++++++++++++++++++++++++++-
1 files changed, 55 insertions(+), 1 deletions(-)
diff --git a/ui/spice-display.c b/ui/spice-display.c
index 973cd53..d062765 100644
--- a/ui/spice-display.c
+++ b/ui/spice-display.c
@@ -239,6 +239,13 @@ static void
qemu_spice_create_one_update(SimpleSpiceDisplay *ssd,
static void qemu_spice_create_update(SimpleSpiceDisplay *ssd)
{
+ static const int blksize = 32;
+ int blocks = (ds_get_width(ssd->ds) + blksize - 1) / blksize;
+ int dirty_top[blocks];
+ int y, yoff, x, xoff, blk, bw;
+ int bpp = ds_get_bytes_per_pixel(ssd->ds);
+ uint8_t *guest, *mirror;
+
if (qemu_spice_rect_is_empty(&ssd->dirty)) {
return;
};
@@ -253,7 +260,54 @@ static void qemu_spice_create_update(SimpleSpiceDisplay
*ssd)
ssd->ds_mirror = g_malloc0(size);
}
- qemu_spice_create_one_update(ssd, &ssd->dirty);
+ for (blk = 0; blk < blocks; blk++) {
+ dirty_top[blk] = -1;
+ }
+
+ guest = ds_get_data(ssd->ds);
+ mirror = ssd->ds_mirror;
+ for (y = ssd->dirty.top; y < ssd->dirty.bottom; y++) {
+ yoff = y * ds_get_linesize(ssd->ds);
+ for (x = ssd->dirty.left; x < ssd->dirty.right; x += blksize) {
+ xoff = x * bpp;
+ blk = x / blksize;
+ bw = MIN(blksize, ssd->dirty.right - x);
+ if (memcmp(guest + yoff + xoff,
+ mirror + yoff + xoff,
+ bw * bpp) == 0) {
+ if (dirty_top[blk] != -1) {
+ QXLRect update = {
+ .top = dirty_top[blk],
+ .bottom = y,
+ .left = x,
+ .right = x + bw,
+ };
+ qemu_spice_create_one_update(ssd, &update);
+ dirty_top[blk] = -1;
+ }
+ } else {
+ if (dirty_top[blk] == -1) {
+ dirty_top[blk] = y;
+ }
+ }
+ }
+ }
+
+ for (x = ssd->dirty.left; x < ssd->dirty.right; x += blksize) {
+ blk = x / blksize;
+ bw = MIN(blksize, ssd->dirty.right - x);
+ if (dirty_top[blk] != -1) {
+ QXLRect update = {
+ .top = dirty_top[blk],
+ .bottom = ssd->dirty.bottom,
+ .left = x,
+ .right = x + bw,
+ };
+ qemu_spice_create_one_update(ssd, &update);
+ dirty_top[blk] = -1;
+ }
+ }
+
memset(&ssd->dirty, 0, sizeof(ssd->dirty));
}
--
1.7.1
- [Qemu-devel] [PULL 00/10] spice patch queue, Gerd Hoffmann, 2012/09/13
- [Qemu-devel] [PATCH 01/10] spice: switch to queue for vga mode updates, Gerd Hoffmann, 2012/09/13
- [Qemu-devel] [PATCH 08/10] hw/qxl: tracing fixes, Gerd Hoffmann, 2012/09/13
- [Qemu-devel] [PATCH 03/10] spice: add screen mirror, Gerd Hoffmann, 2012/09/13
- [Qemu-devel] [PATCH 10/10] hw/qxl: support client monitor configuration via device, Gerd Hoffmann, 2012/09/13
- [Qemu-devel] [PATCH 06/10] qxl: Ignore set_client_capabilities pre/post migrate, Gerd Hoffmann, 2012/09/13
- [Qemu-devel] [PATCH 04/10] spice: send updates only for changed screen content,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH 07/10] qxl: better cleanup for surface destroy, Gerd Hoffmann, 2012/09/13
- [Qemu-devel] [PATCH 09/10] qxl: add trace-event for QXL_IO_LOG, Gerd Hoffmann, 2012/09/13
- [Qemu-devel] [PATCH 05/10] qxl: dont update invalid area, Gerd Hoffmann, 2012/09/13
- [Qemu-devel] [PATCH 02/10] spice: split qemu_spice_create_update, Gerd Hoffmann, 2012/09/13
- Re: [Qemu-devel] [PULL 00/10] spice patch queue, Michael Tokarev, 2012/09/14
- Re: [Qemu-devel] [PULL 00/10] spice patch queue, Anthony Liguori, 2012/09/17