qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/4] tcg/i386: Add shortcuts for registers used


From: Stefan Weil
Subject: Re: [Qemu-devel] [PATCH 2/4] tcg/i386: Add shortcuts for registers used in L constraint
Date: Fri, 14 Sep 2012 07:18:17 +0200
User-agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120827 Thunderbird/15.0

Am 14.09.2012 00:20, schrieb Richard Henderson:
On 09/13/2012 03:03 PM, Peter Maydell wrote:
Hard to come up with a snappy name for "register which is the Nth
input argument if input args are in registers, but an arbitrary
temp reg otherwise, and which is in the forbidden list for the L
constraint"...
I'm more than happy to let "register which is ..." be a comment
just before the definitions of TCG_REG_Ln at the top...



r~


This looks like a pragmatic solution.

If everybody agrees, I'll send an updated patch.

Or Aurelien or Blue can commit this series and fix the comment
as suggested by Richard. Maybe a comment in theprologue code
would also be good.

Thanks to all reviewers.

Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]