[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 10/12] kvm: Fix warning from static code analysis
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 10/12] kvm: Fix warning from static code analysis |
Date: |
Fri, 14 Sep 2012 09:42:24 +0100 |
From: Stefan Weil <address@hidden>
Report from smatch:
kvm-all.c:1373 kvm_init(135) warn:
variable dereferenced before check 's' (see line 1360)
's' cannot by NULL (it was alloced using g_malloc0), so there is no need
to check it here.
Signed-off-by: Stefan Weil <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
kvm-all.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index 39cff55..e5ed3df 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -1409,13 +1409,11 @@ int kvm_init(void)
return 0;
err:
- if (s) {
- if (s->vmfd >= 0) {
- close(s->vmfd);
- }
- if (s->fd != -1) {
- close(s->fd);
- }
+ if (s->vmfd >= 0) {
+ close(s->vmfd);
+ }
+ if (s->fd != -1) {
+ close(s->fd);
}
g_free(s);
--
1.7.10.4
- [Qemu-devel] [PULL 00/12] Trivial patches for 16 August to 14 September 2012, Stefan Hajnoczi, 2012/09/14
- [Qemu-devel] [PATCH 01/12] srp: Don't use QEMU_PACKED for single elements of a structured type, Stefan Hajnoczi, 2012/09/14
- [Qemu-devel] [PATCH 05/12] ui: Fix spelling in comment (ressource -> resource), Stefan Hajnoczi, 2012/09/14
- [Qemu-devel] [PATCH 02/12] Spelling fixes in comments and documentation, Stefan Hajnoczi, 2012/09/14
- [Qemu-devel] [PATCH 04/12] Spelling fixes in comments and macro names (ressource -> resource), Stefan Hajnoczi, 2012/09/14
- [Qemu-devel] [PATCH 03/12] Fix spelling (licenced -> licensed) in GPL, Stefan Hajnoczi, 2012/09/14
- [Qemu-devel] [PATCH 06/12] linux-user: Remove #if 0'd cpu_get_real_ticks() definition, Stefan Hajnoczi, 2012/09/14
- [Qemu-devel] [PATCH 07/12] Fix copy&paste typos in documentation comments, Stefan Hajnoczi, 2012/09/14
- [Qemu-devel] [PATCH 08/12] console: Clean up bytes per pixel calculation, Stefan Hajnoczi, 2012/09/14
- [Qemu-devel] [PATCH 10/12] kvm: Fix warning from static code analysis,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 12/12] configure: fix seccomp check, Stefan Hajnoczi, 2012/09/14
- [Qemu-devel] [PATCH 09/12] qapi: Fix enumeration typo error, Stefan Hajnoczi, 2012/09/14
- [Qemu-devel] [PATCH 11/12] arch_init.c: add missing '%' symbols before PRIu64 in debug printfs, Stefan Hajnoczi, 2012/09/14
- Re: [Qemu-devel] [PULL 00/12] Trivial patches for 16 August to 14 September 2012, Anthony Liguori, 2012/09/17