[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 10/13] net: broadcast hub packets if at least one po
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 10/13] net: broadcast hub packets if at least one port can receive |
Date: |
Fri, 14 Sep 2012 09:46:57 +0100 |
From: Stefan Hajnoczi <address@hidden>
In commit 60c07d933c66c4b30a83b7ccbc8a0cb3df1b2d0e ("net: fix
qemu_can_send_packet logic") the "VLAN" broadcast behavior was changed
to queue packets if any net client cannot receive. It turns out that
this was not actually the right fix and just hides the real bug that
hw/usb/dev-network.c:usbnet_receive() clobbers its receive buffer when
called multiple times in a row. The commit also introduced a new bug
that "VLAN" packets would not be sent if one of multiple net clients was
down.
The hw/usb/dev-network.c bug has since been fixed, so this patch reverts
broadcast behavior to send packets as long as one net client can
receive. Packets simply get queued for the net clients that are
temporarily unable to receive.
Reported-by: Roy.Li <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
net/hub.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/hub.c b/net/hub.c
index ac157e3..650a8b4 100644
--- a/net/hub.c
+++ b/net/hub.c
@@ -97,12 +97,12 @@ static int net_hub_port_can_receive(NetClientState *nc)
continue;
}
- if (!qemu_can_send_packet(&port->nc)) {
- return 0;
+ if (qemu_can_send_packet(&port->nc)) {
+ return 1;
}
}
- return 1;
+ return 0;
}
static ssize_t net_hub_port_receive(NetClientState *nc,
--
1.7.10.4
- [Qemu-devel] [PATCH 01/13] net: notify iothread after flushing queue, (continued)
- [Qemu-devel] [PATCH 01/13] net: notify iothread after flushing queue, Stefan Hajnoczi, 2012/09/14
- [Qemu-devel] [PATCH 03/13] xen: flush queue when getting an event, Stefan Hajnoczi, 2012/09/14
- [Qemu-devel] [PATCH 04/13] eepro100: Fix network hang when rx buffers run out, Stefan Hajnoczi, 2012/09/14
- [Qemu-devel] [PATCH 05/13] net: add receive_disabled logic to iov delivery path, Stefan Hajnoczi, 2012/09/14
- [Qemu-devel] [PATCH 07/13] net: add -netdev options to man page, Stefan Hajnoczi, 2012/09/14
- [Qemu-devel] [PATCH 08/13] net: clean up usbnet_receive(), Stefan Hajnoczi, 2012/09/14
- [Qemu-devel] [PATCH 06/13] net: do not report queued packets as sent, Stefan Hajnoczi, 2012/09/14
- [Qemu-devel] [PATCH 11/13] net: asynchronous send/receive infrastructure for net/socket.c, Stefan Hajnoczi, 2012/09/14
- [Qemu-devel] [PATCH 09/13] net: fix usbnet_receive() packet drops, Stefan Hajnoczi, 2012/09/14
- [Qemu-devel] [PATCH 12/13] net: EAGAIN handling for net/socket.c UDP, Stefan Hajnoczi, 2012/09/14
- [Qemu-devel] [PATCH 10/13] net: broadcast hub packets if at least one port can receive,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 13/13] net: EAGAIN handling for net/socket.c TCP, Stefan Hajnoczi, 2012/09/14
- Re: [Qemu-devel] [PULL 00/13] Net patches, Anthony Liguori, 2012/09/17