Re: [Qemu-devel] directory hierarchy

[Paolo Bonzini]

Il 14/09/2012 15:47, Daniel P. Berrange ha scritto:
> On Fri, Sep 14, 2012 at 03:17:52PM +0200, Paolo Bonzini wrote:
>> Hi all,
>>
>> here is a proposal for moving around 150 C files currently in the
>> toplevel directory to separate, well-delimited subdirectories.  Header
>> files would be moved for now in include/, preparing for subsequent
>> reorganization of headers.
> 
> I tend to view usage of a separate 'include/' subdirectory as a
> location for public facing header files. For internal header
> files, IMHO, its nicer to just have them alongside the .c file
> which has the corresponding implementation.

Yes, me too, but unfortunately almost nothing follows this scheme in
QEMU.  Probably the hw/ files do, but I'm not touching those with a pole.

>> Usually the files would keep their names, but I loathe names starting
>> with qemu-* so I took the occasion to rename those.
> 
> Heh, I would have suggested the opposite - use a 'qemu-' prefix on
> every single file, mostly so that you avoid the confusion where a
> source-local header file happens to have same name as a public
> header file in /usr/include.

Note the above quote is about C files, not headers.

For headers, I would solve the confusion by moving them all in
subdirectories of include/, but not yet.  I want to keep source files
100% unchanged for now.

> I appauld your amibition to modularize the source tree layout
> more. Even if you disagree with my POV on the issues above, it
> would be an improvement.

Oh, on a fresh project I'd agree a lot.  Just trying to do things piecewise.

Paolo