Re: [Qemu-devel] [PATCH 00/25] q35 series take #1

[Kevin Wolf]

Am 14.09.2012 16:12, schrieb Alexander Graf:
> 
> On 14.09.2012, at 16:08, Jason Baron wrote:
> 
>> On Fri, Sep 14, 2012 at 03:56:17PM +0200, Alexander Graf wrote:
>>> On 14.09.2012, at 15:50, Jason Baron wrote:
>>>
>>>> On Fri, Sep 14, 2012 at 12:29:17AM +0200, Alexander Graf wrote:
>>>>> On 13.09.2012, at 22:12, Jason Baron wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Qemu bits for q35 support, I'm posting the seabios changes separately. 
>>>>>> The
>>>>>> patches require '-M pc_q35' and -L 'seabios dir with q35 changes' on the
>>>>>> qemu command line. Hopefully, we can make it the default for x86 at some 
>>>>>> future
>>>>>> point when we feel comfortable with it.
>>>>>
>>>>> Without having had a real look at the code in detail yet, how did you 
>>>>> design the PCI-ISA bridge (LPC device)? I'm asking mostly because Mac OS 
>>>>> X unconditionally accesses that device's PCI config space to find the 
>>>>> base address of the HPET.
>>>>>
>>>>
>>>> The LPC device is inherits from TYPE_PCI_DEVICE, and has modeling for
>>>> configuring pmbase (where the power management io region resides) and
>>>> for configuring pirq irq routing. It does not have the addr for the
>>>> HPET. I'll have to check the spec and see where it resides.
>>>
>>> I have a patch that creates a fake lpc device with the correct regions to 
>>> make osx happy:
>>>
>>>  
>>> http://svn.exactcode.de/t2/trunk/package/emulators/kvm/03-qemu-lpc.patch.disable
>>>
>>> That might be useful as a starting point :).
>>>
>>
>> cool! I'll pull in the bits I'm missing.
> 
> Please make sure to put it at the exact same pci location as it is on real 
> hardware. OSX directly pokes its config space, without searching for it on 
> the bus :).

Sounds like writing a qtest case that checks this would be a good idea
if you want to keep this working long term. Not many people test OS X
guests.

Kevin