Re: [Qemu-devel] [PATCH 1/9] NiosII: Add support for the Altera NiosII soft-core CPU.

[Andreas Färber]

Am 10.09.2012 02:19, schrieb address@hidden:
> From: Chris Wulff <address@hidden>
> 
> Signed-off-by: Chris Wulff <address@hidden>
> ---
>  target-nios2/Makefile.objs |    5 +
>  target-nios2/altera_iic.c  |  100 +++
>  target-nios2/cpu-qom.h     |   69 +++
>  target-nios2/cpu.c         |   83 +++
>  target-nios2/cpu.h         |  259 ++++++++
>  target-nios2/exec.h        |   60 ++
>  target-nios2/helper.c      |  291 +++++++++
>  target-nios2/helper.h      |   45 ++
>  target-nios2/instruction.c | 1463 
> ++++++++++++++++++++++++++++++++++++++++++++
>  target-nios2/instruction.h |  290 +++++++++
>  target-nios2/machine.c     |   33 +
>  target-nios2/mmu.c         |  273 +++++++++
>  target-nios2/mmu.h         |   49 ++
>  target-nios2/op_helper.c   |  125 ++++
>  target-nios2/translate.c   |  252 ++++++++
>  15 files changed, 3397 insertions(+)

Some general comments: You're introducing a new target here, so if you
design your API cleanly (using Nios2CPU where possible) you don't really
need a separate cpu-qom.h file in addition to cpu.h, cf. target-or32.

Please prefer passing Nios2CPU as opaque rather than CPUNios2State
(e.g., 3/9; cf. target-arm). Reason is that fields are being moved from
CPUxxxState to CPUState and this will simplify the migration.

Thanks,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg