Re: [Qemu-devel] [PATCH] ignore more generated files

[Stefan Weil]

Am 16.09.2012 22:55, schrieb Mike Frysinger:
> On Sunday 16 September 2012 16:33:15 Stefan Weil wrote:
> > Am 16.09.2012 22:11, schrieb Mike Frysinger:
> > > +libcacard/vscclient
> > > +a.out*
> > > +.gdb_history
> > > +core
> > > +gmon.out
> > > +*.diff
> > > +*.patch
> > > +*.rej
> > IMHO .gitignore should only contain files which are generated
> > by a normal QEMU build.
> >
> > a.out*, .gdb_history, core, *.diff, *patch, *.rej are not QEMU specific
> > and should be ignored in the user's GIT configuration.
> these files show up a lot when doing development on qemu, hence i think they do
> make sense to be listed here.  it also makes things "just work" for all users
> rather than requiring every one to set up their local system in the same way.
> plus, that would conflict with repos that do want to merge these types of files
> (uncommon, but not unheard of as test inputs).
>
> it's not like entries in this file "cost" anything at all.
> -mike

Yes, these files show up when doing development, but not only on
QEMU. They are not at all QEMU specific. I assume that most developers
also have other projects which they work on, so IMHO ignoring those
files in their user settings makes more sense.

I personally would prefer to see *.rej files. Your patch ignores
them (which is not what I want). Therefore the claim
that those entries make thinks "just work" for all users is not true:
it's at least all users minus one.

See more in a previous mail on the same subject:
http://lists.gnu.org/archive/html/qemu-devel/2011-02/msg03017.html
(there was also another discussion thread which I did not find
any more).

You can also have a look at other project's .gitignore.
Linux' .gitignore for example looks much better than QEMU's.
It has comments (good!) and only very few entries which are not
generated files.

- Stefan