qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] ignore more generated files


From: Jan Kiszka
Subject: Re: [Qemu-devel] [PATCH] ignore more generated files
Date: Mon, 17 Sep 2012 09:19:54 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2012-09-16 22:55, Mike Frysinger wrote:
> On Sunday 16 September 2012 16:33:15 Stefan Weil wrote:
>> Am 16.09.2012 22:11, schrieb Mike Frysinger:
>>> +libcacard/vscclient +a.out* +.gdb_history +core +gmon.out 
>>> +*.diff +*.patch +*.rej
>> 
>> IMHO .gitignore should only contain files which are generated by 
>> a normal QEMU build.
>> 
>> a.out*, .gdb_history, core, *.diff, *patch, *.rej are not QEMU 
>> specific and should be ignored in the user's GIT configuration.
> 
> these files show up a lot when doing development on qemu, hence i 
> think they do make sense to be listed here.  it also makes things 
> "just work" for all users rather than requiring every one to set
> up their local system in the same way. plus, that would conflict
> with repos that do want to merge these types of files (uncommon,
> but not unheard of as test inputs).
> 
> it's not like entries in this file "cost" anything at all.

NAK. I'd like to see what is polluting my repositories, not ignoring
it because that's the policy of someone else. Excluding *.rej is
something I would _never_ do. If they lie around somewhere, something
was not merged here - that's my policy.

You are free to set your own core.excludefile. So please do not spread
this to generic .gitignores.

Jan

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iEYEARECAAYFAlBWzxoACgkQitSsb3rl5xQk5ACgoRORiSgWkWlhkz4YdE2zQ1ZB
moUAoK8D5khm+Tz9QrcvKoAhpHOmz5pA
=FgFo
-----END PGP SIGNATURE-----



reply via email to

[Prev in Thread] Current Thread [Next in Thread]