Re: [Qemu-devel] [RFC v0 09/10] microblaze_generic_fdt: first revision

[Andreas Färber]

Am 17.09.2012 11:03, schrieb Peter A. G. Crosthwaite:
> First revision of fdt generic platform for xilinx microblaze platforms.
> Adds machine model "microblaze-fdt" which can be used along with the --hw-dtb
> option to lauch dts driven machine models for microblaze platforms.
> 
> Signed-off-by: Peter A. G. Crosthwaite <address@hidden>
> ---
>  hw/microblaze/Makefile.objs |    1 +
>  hw/microblaze_generic_fdt.c |  378 
> +++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 379 insertions(+), 0 deletions(-)
>  create mode 100644 hw/microblaze_generic_fdt.c
> 
> diff --git a/hw/microblaze/Makefile.objs b/hw/microblaze/Makefile.objs
> index ef2d6b7..be3aaa5 100644
> --- a/hw/microblaze/Makefile.objs
> +++ b/hw/microblaze/Makefile.objs
> @@ -1,5 +1,6 @@
>  obj-y = petalogix_s3adsp1800_mmu.o
>  obj-y += petalogix_ml605_mmu.o
> +obj-y += microblaze_generic_fdt.o
>  obj-y += microblaze_boot.o
>  
>  obj-y += microblaze_pic_cpu.o
[snip]

Since this file clearly is MicroBlaze-specific, I suggest to place it in
hw/microblaze/generic_fdt.c instead. (CC'ing Mr. Makefile)

Cheers,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg