[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] target-arm: convert shl and shr helpers to
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/5] target-arm: convert shl and shr helpers to TCG |
|
Date: |
Mon, 17 Sep 2012 08:36:31 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 |
On 09/16/2012 04:08 PM, Aurelien Jarno wrote:
> + tcg_gen_setcondi_i32(TCG_COND_GE, tmp2, tmp1, 32); \
> + tcg_gen_andi_i32(tmp1, tmp1, 0x1f); \
> + tcg_gen_##name##_i32(dest, t0, tmp1); \
> + tcg_temp_free_i32(tmp1); \
> + tcg_gen_subi_i32(tmp2, tmp2, 1); \
> + tcg_gen_and_i32(dest, dest, tmp2); \
Ought I revive my movcond patch?
Surely you can agree it's much more natural to write this
as a conditional move of zero than playing masking games.
r~
Re: [Qemu-devel] [PATCH 3/5] target-arm: convert shl and shr helpers to TCG,
Richard Henderson <=
[Qemu-devel] [PATCH 5/5] target-arm: mark a few integer helpers const and pure, Aurelien Jarno, 2012/09/16
[Qemu-devel] [PATCH 4/5] target-arm: optimize helper_sar, Aurelien Jarno, 2012/09/16
[Qemu-devel] [PATCH 2/5] target-arm: convert add_cc and sub_cc helpers to TCG, Aurelien Jarno, 2012/09/16
[Qemu-devel] [PATCH 1/5] target-arm: use globals for CC flags, Aurelien Jarno, 2012/09/16