Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG

[Anthony Liguori]

Mike Frysinger <address@hidden> writes:

> We should not quote the PKG_CONFIG setting as this deviates from the
> canonical upstream behavior that gets integrated with all other build
> systems, and deviates from how we treat all other toolchain variables
> that we get from the environment.
>
> Ultimately, the point is that it breaks passing custom flags directly
> to pkg-config via the env var where this normally works elsewhere,
> and it used to work in the past.
>
> Signed-off-by: Mike Frysinger <address@hidden>

This doesn't make any sense to me.   What is the command line that
you're trying to execute?

This obviously would introduce a bug if there was a space in the
filename of the pkg-config binary.

Regards,

Anthony Liguori

> ---
>  configure |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 83fa1ca..bd12ed3 100755
> --- a/configure
> +++ b/configure
> @@ -245,7 +245,7 @@ strip="${STRIP-${cross_prefix}strip}"
>  windres="${WINDRES-${cross_prefix}windres}"
>  pkg_config_exe="${PKG_CONFIG-${cross_prefix}pkg-config}"
>  query_pkg_config() {
> -    "${pkg_config_exe}" ${QEMU_PKG_CONFIG_FLAGS} "$@"
> +    ${pkg_config_exe} ${QEMU_PKG_CONFIG_FLAGS} "$@"
>  }
>  pkg_config=query_pkg_config
>  sdl_config="${SDL_CONFIG-${cross_prefix}sdl-config}"
> @@ -1511,7 +1511,7 @@ fi
>  ##########################################
>  # pkg-config probe
>  
> -if ! has "$pkg_config_exe"; then
> +if ! has $pkg_config_exe; then
>    echo "Error: pkg-config binary '$pkg_config_exe' not found"
>    exit 1
>  fi
> -- 
> 1.7.9.7