qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 000/126] Rewrite s390x translator


From: Alexander Graf
Subject: Re: [Qemu-devel] [PATCH 000/126] Rewrite s390x translator
Date: Tue, 18 Sep 2012 23:09:52 +0200
User-agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0

On 09/18/2012 11:08 PM, Alexander Graf wrote:
On 09/09/2012 11:04 PM, Richard Henderson wrote:
As promised the other week.  I've cleaned up the patch set and
re-based it on Blueswirl's areg0 patch set.  For reference, the
entire patch set is available at

   git://repo.or.cz/qemu/rth.git rth/s390-reorg-3

Testing has mostly been on the gcc testsuite, where the execute
test failures are reduced to

FAIL: gcc.dg/attr-ifunc-1.c execution test
FAIL: gcc.dg/attr-ifunc-3.c execution test
FAIL: gcc.dg/attr-ifunc-4.c execution test
FAIL: gcc.dg/attr-ifunc-5.c execution test
FAIL: gcc.dg/cdce1.c execution test
FAIL: gcc.dg/cleanup-11.c execution test
FAIL: gcc.dg/cleanup-9.c execution test
FAIL: gcc.dg/torture/pr41094.c  -O0  execution test
FAIL: gcc.dg/torture/tls/tls-test.c * execution test

I'll probably start trying out the glibc testsuite next, as
that's quite likely to flush out remaining problems with the
fp support (both cdce1 and pr41094 are both failures in pow).

I've also done some testing with -march={z10,z196}, but I
don't have those results handy atm.

So I've had a look at the patch set. Overall it looks ok. I have to admit that I found the old code a lot easier to understand and read. But if you want to keep maintaining it the new way, I'm definitely ok with that as well :).

Also, 102-126 are missing for me :).


Alex




reply via email to

[Prev in Thread] Current Thread [Next in Thread]