Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman

[Gerd Hoffmann]

On 09/18/12 22:30, Søren Sandmann wrote:
> Gerd Hoffmann <address@hidden> writes:
> 
>> +static pixman_image_t *pixman_from_displaystate(DisplayState *ds)
>> +{

>> +static pixman_image_t *pixman_from_framebuffer(void)
>> +{

> You may want to call pixman_format_supported_source/destination() here
> to ensure that the format in question is supported by pixman.

Ok.

>> +    pixman_region_fini(&dirty);
>> +    pixman_region_init(&dirty);
>>  }
> 
> The fini()/init() here could be done with pixman_region_clear() which
> was introduced in 0.26.0.

Saw that, but rhel6 ships 0.18.something which hasn't this function yet.

cheers,
  Gerd