qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qapi: convert add_client


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH] qapi: convert add_client
Date: Wed, 19 Sep 2012 09:08:30 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)

Luiz Capitulino <address@hidden> writes:

> On Tue, 18 Sep 2012 13:13:16 -0600
> Eric Blake <address@hidden> wrote:
>
>> On 09/18/2012 01:06 PM, Luiz Capitulino wrote:
>> > Also fixes a few issues while there:
>> > 
>> >  1. The fd returned by monitor_get_fd() leaks in most error conditions
>> >  2. monitor_get_fd() return value is not checked. Best case we get
>> >     an error that is not correctly reported, worse case one of the
>> >     functions using the fd (with value of -1) will explode
>> >  3. A few error conditions aren't reported
>> > 
>> > Signed-off-by: Luiz Capitulino <address@hidden>
>> > ---
>> >  monitor.c        | 39 ---------------------------------------
>> >  qapi-schema.json | 23 +++++++++++++++++++++++
>> >  qmp-commands.hx  |  5 +----
>> >  qmp.c            | 44 ++++++++++++++++++++++++++++++++++++++++++++
>> >  4 files changed, 68 insertions(+), 43 deletions(-)
>> > 
>> 
>> >  { 'command': 'screendump', 'data': {'filename': 'str'} }
>> > +
>> > +##
>> > +# @add_client
[...]
>> If this were a new command for 1.3, I'd say to name it 'add-client'; but
>> since QMP has already been exposing it and you are now just documenting
>> it, you can't change the name.
>
> Yes, we just have to live with that for all old commands.

If the inconsistency bothers us, we can either

* add suitable aliases for every QMP name containing '_', or

* fix the QMP names, and fold '_' to '-' in names received from client.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]