Re: [Qemu-devel] [PATCH 010/126] target-s390: Reorg exception handling

[Alexander Graf]

On 19.09.2012, at 16:34, Richard Henderson wrote:

> On 09/19/2012 06:02 AM, Alexander Graf wrote:
>> Richard, please double-check all the ilc passing again with the spec.
> 
> I'll look again.
> 
> But I do recall that the spec is consistent in placing a 3-bit field (values 
> 1-3)
> shifted one bit left into the larger 32-bit field, so that in essence the 
> value
> is always the real instruction length.
> 
> However, qemu was not consistent in performing that multiplication.  So there
> will be some place that gets changed because of this.  Frankly I think it 
> would
> be least confusing to always manipulate the full instruction length and never
> explicitly perform the multiply.

I agree. How about we rename the whole thing to inst_len and then just modify 
it accordingly when we move it into the exception area?


Alex