[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/12] qmp: add NBD server commands
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 14/12] qmp: add NBD server commands |
Date: |
Wed, 19 Sep 2012 11:48:17 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 |
On 09/19/2012 08:31 AM, Paolo Bonzini wrote:
> Adding an NBD server inside QEMU is trivial, since all the logic is
> in nbd.c and can be shared easily between qemu-nbd and QEMU itself.
> The main difference is that qemu-nbd serves a single unnamed export,
> while QEMU serves named exports.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> +##
> +# @nbd-server-add:
> +#
> +# Export a device to QEMU's embedded NBD server.
> +#
> +# @device: Block device to be exported
> +#
> +# @writable: Whether clients should be able to write to the device via the
> +# NBD connection (default false). #optional
Again, shouldn't #optional be first after the colon?
> +#
> +# Returns: error if the device is already marked for export.
> +#
> +# Since: 1.3.0
> +##
> +{ 'command': 'nbd-server-add', 'data': {'device': 'str', '*writable':
> 'bool'} }
> +
> +##
> +# @nbd-server-stop:
> +#
> +# Stop QEMU's embedded NBD server, and unregister all devices previously
> +# added via @nbd-server-add.
Do we need a way to unregister a single device, rather than having to
stop the NBD server to unregister all devices?
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 04/12] qapi: add "unix" to the set of reserved words, (continued)
[Qemu-devel] [PATCH 06/12] qapi: add socket address types, Paolo Bonzini, 2012/09/19
[Qemu-devel] [PATCH 07/12] qemu-sockets: add error propagation to inet_parse, Paolo Bonzini, 2012/09/19
[Qemu-devel] [PATCH 08/12] qemu-sockets: add error propagation to Unix socket functions, Paolo Bonzini, 2012/09/19
[Qemu-devel] [PATCH 12/12] qemu-sockets: add socket_listen, socket_connect, socket_parse, Paolo Bonzini, 2012/09/19
[Qemu-devel] [PATCH 13/12] block: add close notifiers, Paolo Bonzini, 2012/09/19
[Qemu-devel] [PATCH 14/12] qmp: add NBD server commands, Paolo Bonzini, 2012/09/19
- Re: [Qemu-devel] [PATCH 14/12] qmp: add NBD server commands,
Eric Blake <=
[Qemu-devel] [PATCH 10/12] qemu-sockets: move block from QemuOpts to arguments, Paolo Bonzini, 2012/09/19
[Qemu-devel] [PATCH 11/12] qemu-sockets: add block and in_progress arguments to unix_connect_opts, Paolo Bonzini, 2012/09/19
[Qemu-devel] [PATCH 15/12] hmp: add NBD server commands, Paolo Bonzini, 2012/09/19
[Qemu-devel] [PATCH 09/12] qemu-sockets: return IPSocketAddress from inet_parse, Paolo Bonzini, 2012/09/19