[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V3 5/5] xen: Set the vram dirty when an error oc
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PATCH V3 5/5] xen: Set the vram dirty when an error occur. |
Date: |
Thu, 20 Sep 2012 13:31:35 +0100 |
User-agent: |
Alpine 2.02 (DEB 1266 2009-07-14) |
On Thu, 20 Sep 2012, Anthony PERARD wrote:
> If the call to xc_hvm_track_dirty_vram() fails, then we set dirtybit on all
> the
> video ram. This case happens during migration, but we don't need a special
> case
> for live migration with patch.
Just as a reference, what is this special case for live migration that
you are talking about? A pointer to the qemu-xen-traditional code would
be welcomed here.
> Signed-off-by: Anthony PERARD <address@hidden>
> ---
> xen-all.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/xen-all.c b/xen-all.c
> index 6250593..ab28261 100644
> --- a/xen-all.c
> +++ b/xen-all.c
> @@ -507,7 +507,8 @@ static void xen_sync_dirty_bitmap(XenIOState *state,
> bitmap);
> if (rc < 0) {
> if (rc != -ENODATA) {
> - fprintf(stderr, "xen: track_dirty_vram failed (0x" TARGET_FMT_plx
> + memory_region_set_dirty(framebuffer, 0, size);
> + DPRINTF("xen: track_dirty_vram failed (0x" TARGET_FMT_plx
> ", 0x" TARGET_FMT_plx "): %s\n",
> start_addr, start_addr + size, strerror(-rc));
> }
> --
> Anthony PERARD
>
- [Qemu-devel] [PATCH V3 0/5] Xen, introducing dirty log for migration., Anthony PERARD, 2012/09/20
- [Qemu-devel] [PATCH V3 4/5] exec, memory: Call to xen_modified_memory., Anthony PERARD, 2012/09/20
- [Qemu-devel] [PATCH V3 2/5] xen: Introduce xen_modified_memory., Anthony PERARD, 2012/09/20
- [Qemu-devel] [PATCH V3 5/5] xen: Set the vram dirty when an error occur., Anthony PERARD, 2012/09/20
- Re: [Qemu-devel] [PATCH V3 5/5] xen: Set the vram dirty when an error occur.,
Stefano Stabellini <=
- [Qemu-devel] [PATCH V3 1/5] QMP, Introduce xen-set-global-dirty-log command., Anthony PERARD, 2012/09/20
- [Qemu-devel] [PATCH V3 3/5] exec: Introduce helper to set dirty flags., Anthony PERARD, 2012/09/20