[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] tcg: Introduce movcond
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/5] tcg: Introduce movcond |
|
Date: |
Thu, 20 Sep 2012 15:47:19 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 |
On 09/20/2012 03:06 PM, Aurelien Jarno wrote:
>> > + if (TCG_TARGET_HAS_movcond_i64) {
>> > + tcg_gen_op6i_i64(INDEX_op_movcond_i64, ret, c1, c2, v1, v2, cond);
>> > + return;
> Minor nitpick: there is useless return here, and it's not present for
> movcond_i32.
>
Ah, right. I started to add a case for implementing movcond_i64
with movcond_i32, but didn't finish.
r~
- Re: [Qemu-devel] [PATCH 5/5] tcg: Optimize two-address commutative operations, (continued)
- [Qemu-devel] [PATCH 4/5] tcg: Optimize movcond for constant comparisons, Richard Henderson, 2012/09/18
- [Qemu-devel] [PATCH 3/5] tcg-i386: Implement movcond, Richard Henderson, 2012/09/18
- [Qemu-devel] [PATCH 2/5] target-alpha: Use movcond, Richard Henderson, 2012/09/18
- [Qemu-devel] [PATCH 1/5] tcg: Introduce movcond, Richard Henderson, 2012/09/18
- Re: [Qemu-devel] [PATCH 0/5] tcg: movcond, Aurelien Jarno, 2012/09/18