Re: [Qemu-devel] [PATCH v4 02/17] target-i386: Add missing kvm bits.

[Igor Mammedov]

On Thu, 20 Sep 2012 16:03:17 -0400
Don Slutz <address@hidden> wrote:

> Fix duplicate name (kvmclock => kvm_clock2) also.
> 
> Signed-off-by: Don Slutz <address@hidden>
> ---
>  target-i386/cpu.c |   12 ++++++++----
>  1 files changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 0313cf5..5f9866a 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -87,10 +87,14 @@ static const char *ext3_feature_name[] = {
>  };
>  
>  static const char *kvm_feature_name[] = {
> -    "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", 
> NULL, "kvm_pv_eoi", NULL,
> -    NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> -    NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> -    NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> +    "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvm_clock2",
before patch if "kvmclock" is specified it would set 0 and 3 bits,
after patch only bit 0 is set.
Is it correct/expected behavior? if yes, please add rationale into patch
description.
 
> +    "kvm_asyncpf", "kvm_steal_time", "kvm_pv_eoi", NULL,
> +    NULL, NULL, NULL, NULL,
> +    NULL, NULL, NULL, NULL,
> +    NULL, NULL, NULL, NULL,
> +    NULL, NULL, NULL, NULL,
> +    "kvm_clock_stable", NULL, NULL, NULL,
> +    NULL, NULL, NULL, NULL,
>  };
>  
>  static const char *svm_feature_name[] = {
> -- 
> 1.7.1
> 


-- 
Regards,
  Igor