qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/9] fbdev: add linux framebuffer display driver


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 4/9] fbdev: add linux framebuffer display driver.
Date: Fri, 21 Sep 2012 14:28:34 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.7) Gecko/20120825 Thunderbird/10.0.7

  Hi,

>> +    case FB_ACQ_REQ:
>> +        fbdev_switch_acquire();
>> +        redraw_screen++;
> 
> Rather than introducing redraw_screen, I would just call vga_hw_invalidate
> instead here. It is always a win if we can avoid to introduce one more
> state machine.

Wouldn't that make the vga emulation do additional work which is simply
not needed?

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]