[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 23/41] buffered_file: We can access directly to
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 23/41] buffered_file: We can access directly to bandwidth_limit |
Date: |
Fri, 21 Sep 2012 14:35:53 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
Il 21/09/2012 10:47, Juan Quintela ha scritto:
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> buffered_file.c | 5 ++---
> buffered_file.h | 3 +--
> migration.c | 2 +-
> 3 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/buffered_file.c b/buffered_file.c
> index 4fca774..43e68b6 100644
> --- a/buffered_file.c
> +++ b/buffered_file.c
> @@ -222,15 +222,14 @@ static void buffered_rate_tick(void *opaque)
> buffered_put_buffer(s, NULL, 0, 0);
> }
>
> -QEMUFile *qemu_fopen_ops_buffered(MigrationState *migration_state,
> - size_t bytes_per_sec)
> +QEMUFile *qemu_fopen_ops_buffered(MigrationState *migration_state)
> {
> QEMUFileBuffered *s;
>
> s = g_malloc0(sizeof(*s));
>
> s->migration_state = migration_state;
> - s->xfer_limit = bytes_per_sec / 10;
> + s->xfer_limit = migration_state->bandwidth_limit / 10;
>
> s->file = qemu_fopen_ops(s, buffered_put_buffer, NULL,
> buffered_close, buffered_rate_limit,
> diff --git a/buffered_file.h b/buffered_file.h
> index 8a38754..ef010fe 100644
> --- a/buffered_file.h
> +++ b/buffered_file.h
> @@ -17,7 +17,6 @@
> #include "hw/hw.h"
> #include "migration.h"
>
> -QEMUFile *qemu_fopen_ops_buffered(MigrationState *migration_state,
> - size_t xfer_limit);
> +QEMUFile *qemu_fopen_ops_buffered(MigrationState *migration_state);
>
> #endif
> diff --git a/migration.c b/migration.c
> index 6f1e4d3..56014dd 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -427,7 +427,7 @@ void migrate_fd_connect(MigrationState *s)
> int ret;
>
> s->state = MIG_STATE_ACTIVE;
> - s->file = qemu_fopen_ops_buffered(s, s->bandwidth_limit);
> + s->file = qemu_fopen_ops_buffered(s);
>
> DPRINTF("beginning savevm\n");
> ret = qemu_savevm_state_begin(s->file, &s->params);
>
Reviewed-by: Paolo Bonzini <address@hidden>
Paolo
- [Qemu-devel] [PATCH 22/41] buffered_file: unfold migrate_fd_put_buffer, (continued)
- [Qemu-devel] [PATCH 22/41] buffered_file: unfold migrate_fd_put_buffer, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 21/41] buffered_file: unfold migrate_fd_put_buffer, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 19/41] buffered_file: unfold migrate_fd_put_buffer, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 15/41] migration: Add dirty_pages_rate to query migrate output, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 27/41] savevm: unexport qemu_fflush, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 23/41] buffered_file: We can access directly to bandwidth_limit, Juan Quintela, 2012/09/21
- Re: [Qemu-devel] [PATCH 23/41] buffered_file: We can access directly to bandwidth_limit,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 26/41] migration: make migrate_fd_wait_for_unfreeze() return errors, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 29/41] savevm: Remove qemu_fseek(), Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 30/41] savevm: make qemu_fflush() return an error code, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 38/41] block-migration: handle errors with the return codes correctly, Juan Quintela, 2012/09/21