[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/10] tcg/mips: don't use global pointer
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH 04/10] tcg/mips: don't use global pointer |
|
Date: |
Fri, 21 Sep 2012 11:18:39 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 |
On 09/21/2012 09:43 AM, Aurelien Jarno wrote:
> Don't use the global pointer in TCG, in case helpers try access global
> variables.
Err.. isn't the GP computed at the entry point of functions that need to use it?
That said, under n32 and n64 abis it is call-saved; under o32 it's
call-clobbered.
So by itself this is still a fix for new-abis, since we don't save it in the
prologue. OTOH, this does suggest an alternate solution... ;-)
r~
- [Qemu-devel] [PATCH 00/10] tcg/mips: cleanup and improvements, Aurelien Jarno, 2012/09/21
- [Qemu-devel] [PATCH 09/10] tcg/mips: implement deposit op on MIPS32R2, Aurelien Jarno, 2012/09/21
- [Qemu-devel] [PATCH 07/10] tcg/mips: optimize bswap{16, 16s, 32} on MIPS32R2, Aurelien Jarno, 2012/09/21
- [Qemu-devel] [PATCH 01/10] tcg-mips: fix wrong usage of 'Z' constraint, Aurelien Jarno, 2012/09/21
- [Qemu-devel] [PATCH 04/10] tcg/mips: don't use global pointer, Aurelien Jarno, 2012/09/21
- Re: [Qemu-devel] [PATCH 04/10] tcg/mips: don't use global pointer,
Richard Henderson <=
- [Qemu-devel] [PATCH 10/10] tcg/mips: implement movcond op on MIPS32R2, Aurelien Jarno, 2012/09/21
- [Qemu-devel] [PATCH 08/10] tcg/mips: implement rotl/rotr ops on MIPS32R2, Aurelien Jarno, 2012/09/21
- [Qemu-devel] [PATCH 05/10] tcg/mips: use stack for TCG temps, Aurelien Jarno, 2012/09/21
[Qemu-devel] [PATCH 02/10] tcg/mips: kill warnings in user mode, Aurelien Jarno, 2012/09/21
[Qemu-devel] [PATCH 06/10] tcg/mips: optimize brcond arg, 0, Aurelien Jarno, 2012/09/21