[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/1] target-i386: Fix default Hypervisor leve
From: |
Don Slutz |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/1] target-i386: Fix default Hypervisor level for hypervisor-vendor=kvm. |
Date: |
Fri, 21 Sep 2012 16:26:58 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:15.0) Gecko/20120907 Thunderbird/15.0.1 |
On 09/21/12 10:18, Eduardo Habkost wrote:
On Thu, Sep 20, 2012 at 04:06:27PM -0400, Don Slutz wrote:
From http://lkml.indiana.edu/hypermail/linux/kernel/1205.0/00100.html
EAX should be KVM_CPUID_FEATURES (0x40000001) not 0.
Added hypervisor-vendor=kvm0 to get the older CPUID result. kvm1 selects the
newer one.
Why not just make "hypervisor-vendor=kvm" control only the hypervisor
vendor string, and support something like "kvm-hypervisor-level=0" to
restore the old cpuid_hv_level=0 behavior?
-cpu host,hypervisor-vendor=kvm,hypervisor-level=0
Does this.
This is similar to the kvmclock case: it would allow us to make
"hypervisor-vendor=kvm" use saner values as default, but letting old
machine-types to override it for compatibility if required.
Right now since I am using env->cpuid_hv_level == 0 as a flag. This
means that:
-cpu host,hypervisor-level=0,hypervisor-vendor=kvm
-cpu host,hypervisor-vendor=kvm,hypervisor-level=0
end up with different CPUID data (Which I do not like). I will fix this in the
next round.
Did you want me to drop kvm0 and kvm1?
-Don
[...]