qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 07/10] tcg/optimize: further optimize brcond/


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v2 07/10] tcg/optimize: further optimize brcond/movcond/setcond
Date: Sat, 22 Sep 2012 05:46:16 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1

On 2012-09-22 02:35, Aurelien Jarno wrote:
> On Fri, Sep 21, 2012 at 04:17:08PM -0700, Richard Henderson wrote:
>> On 09/21/2012 12:43 PM, Aurelien Jarno wrote:
>>> +/* Return 2 if the condition can't be simplified, and the result
>>> +   of the condition (0 or 1) if it can */
>>
>> Ok as-is.  But I'd bike-shed the "fail" return to -1.
>>
> 
> I have done it that way, as tmp is an unsigned value, and I didn't want
> to add another one. But that can be changed.
> 

Fair enough.  Green it is for the shed.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]