Re: [Qemu-devel] [RFC v2 1/2] target-arm: Prepare support for Cortex-R4

[Peter Maydell]

On 22 September 2012 12:45, Andreas Färber <address@hidden> wrote:
> +static void cortex_r4_initfn(Object *obj)
> +{
> +    ARMCPU *cpu = ARM_CPU(obj);
> +    set_feature(&cpu->env, ARM_FEATURE_V7);
> +    set_feature(&cpu->env, ARM_FEATURE_THUMB_DIV);
> +    set_feature(&cpu->env, ARM_FEATURE_MPU);

This will trip the assert in register_cp_regs_for_features():

    if (arm_feature(env, ARM_FEATURE_MPU)) {
        /* These are the MPU registers prior to PMSAv6. Any new
         * PMSA core later than the ARM946 will require that we
         * implement the PMSAv6 or PMSAv7 registers, which are
         * completely different.
         */
        assert(!arm_feature(env, ARM_FEATURE_V6));

...indicating that R4 support is more work than is contained
in this patch :-)

-- PMM