[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 3/4] Fix address handling in inet_nonblocking
From: |
Orit Wasserman |
Subject: |
Re: [Qemu-devel] [PATCH v4 3/4] Fix address handling in inet_nonblocking_connect |
Date: |
Mon, 24 Sep 2012 12:11:07 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120827 Thunderbird/15.0 |
On 09/24/2012 12:10 PM, Michael S. Tsirkin wrote:
> On Sun, Sep 23, 2012 at 04:49:06PM +0200, Orit Wasserman wrote:
>> diff --git a/qemu_socket.h b/qemu_socket.h
>> index 3247fb7..da93509 100644
>> --- a/qemu_socket.h
>> +++ b/qemu_socket.h
>> @@ -38,20 +38,31 @@ void socket_set_block(int fd);
>> void socket_set_nonblock(int fd);
>> int send_all(int fd, const void *buf, int len1);
>>
>> +/* callback function for nonblocking connect
>> + * vaild fd on success, negative error code on failure
>
> typo
>
>> + */
>> +typedef void ConnectHandler(int fd, void *opaque);
>
> Can we rename this NonBlockingConnectHandler?
Of course.
>
>> +
>> /* New, ipv6-ready socket helper functions, see qemu-sockets.c */
>
> BTW let's kill this comment.
>
Re: [Qemu-devel] [PATCH v4 0/4] nonblocking connect address handling cleanup, Michael S. Tsirkin, 2012/09/23
Re: [Qemu-devel] [PATCH v4 0/4] nonblocking connect address handling cleanup, Markus Armbruster, 2012/09/24