Re: [Qemu-devel] [PATCH v9 2/4] qemu: URI parsing library

[Richard W.M. Jones]

On Mon, Sep 24, 2012 at 02:42:02PM +0530, Bharata B Rao wrote:
> qemu: URI parsing library
> 
> From: Paolo Bonzini <address@hidden>
> 
> Add a new URI parsing library to QEMU. The code has been borrowed from
> libxml2 and libvirt.

Rather than duplicating the libxml2 code, I think it would be better
to depend on libxml2.  While it's not ideal to add more external
dependencies, libxml2 is very commonly available.  Also libxml2 gets
frequent security updates and you never know when the URI code here
might be found to contain some sort of bug / security issue.

This will need a change to the qemu configure script of course.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/