Re: [Qemu-devel] [PATCH 3/7] tcg-i386: Implement movcond

[Richard Henderson]

On 09/24/2012 02:37 PM, Alex Barcelo wrote:
> just finished a git-bisect and I found this... and now I do not fully
> understand why I have the problem.
> 
> To replicate the error (in a i386 machine, at least):
> $ make clean && ./configure --enable-debug && make -j && make install
> [Note: I tried both ppc and i386 targets, so doesn't seem machine-dependent]
> $ ./path/to/qemu/bin/qemu-i386 doesntmatter
> Invalid op definition for movcond_i32
> /mnt/DATA/DARCO/qemu-git/tcg/tcg.c:1170: tcg fatal error
> Aborted

Ah, right.  I only tried with -march=i686.

>> +    { INDEX_op_movcond_i32, { "r", "r", "ri", "r", "0" } },

Should be protected by 

#if TCG_TARGET_HAS_movcond_i32

If no one beats me to this, I'll submit a patch this evening.


r~