[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device ser
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization |
Date: |
Tue, 25 Sep 2012 08:37:16 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
Il 24/09/2012 20:14, Michael Roth ha scritto:
>>> > > I went with qUppercase because it avoids all the previous issues with
>>> > > using leading underscores, and it's reserved in terms of QEMU coding
>>> > > guidelines as far as I can tell (we generally require leading capital
>>> > > for typedefs and lowercase for variable names, and can work around
>>> > > exceptions on a case by case basis by using QIDL() or some other name).
>>> > > I also had it as q_* for a bit but that didn't seem much better on the
>>> > > eyes we looking at converted structures.
>> >
>> > It looks like Hungarian notation and very much unlike other QEMU code.
>> > I'd use q_ or qidl_ prefix instead, or rather QIDL().
>> >
> I wanted some way to distinguish from other qemu code to avoid conflicts,
> but i think q_* seems reasonable if we reserve the prefix via CODING_STYLE.
> Then for conflicts outside our control we can either use a different name
> for the annotations or use the long-form QIDL() style depending on the
> circumstances.
I'm not sure why we need two ways to say the same thing... I know it's
just bikeshedding to some extent, but I'd really like to standardize on
a single form.
Paolo
- [Qemu-devel] [PATCH 19/22] qidl: add C parser (based on QC parser), (continued)
- Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization, Paolo Bonzini, 2012/09/21
- Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization, Michael Roth, 2012/09/21
- Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization, Blue Swirl, 2012/09/22
- Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization, Michael Roth, 2012/09/24
- Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization, Michael Roth, 2012/09/25
- Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization, Anthony Liguori, 2012/09/25
- Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization, Paolo Bonzini, 2012/09/26
- Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization, Kevin Wolf, 2012/09/26
- Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization, Paolo Bonzini, 2012/09/26
- Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization, Michael Roth, 2012/09/26
[Qemu-devel] [PATCH 16/22] qdev: move Property-related declarations to qdev-properties.h, Michael Roth, 2012/09/21