[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/41] migration: rename expected_time to expect
From: |
Orit Wasserman |
Subject: |
Re: [Qemu-devel] [PATCH 05/41] migration: rename expected_time to expected_downtime |
Date: |
Tue, 25 Sep 2012 10:21:29 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120827 Thunderbird/15.0 |
On 09/21/2012 11:46 AM, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> arch_init.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/arch_init.c b/arch_init.c
> index cdd8ab7..013e5e5 100644
> --- a/arch_init.c
> +++ b/arch_init.c
> @@ -539,7 +539,7 @@ static int ram_save_iterate(QEMUFile *f, void *opaque)
> double bwidth = 0;
> int ret;
> int i;
> - uint64_t expected_time;
> + uint64_t expected_downtime;
>
> bytes_transferred_last = bytes_transferred;
> bwidth = qemu_get_clock_ns(rt_clock);
> @@ -578,24 +578,24 @@ static int ram_save_iterate(QEMUFile *f, void *opaque)
> bwidth = qemu_get_clock_ns(rt_clock) - bwidth;
> bwidth = (bytes_transferred - bytes_transferred_last) / bwidth;
>
> - /* if we haven't transferred anything this round, force expected_time to
> a
> - * a very high value, but without crashing */
> + /* if we haven't transferred anything this round, force
> + * expected_downtime to a very high value, but without
> + * crashing */
> if (bwidth == 0) {
> bwidth = 0.000001;
> }
>
> qemu_put_be64(f, RAM_SAVE_FLAG_EOS);
>
> - expected_time = ram_save_remaining() * TARGET_PAGE_SIZE / bwidth;
> + expected_downtime = ram_save_remaining() * TARGET_PAGE_SIZE / bwidth;
> + DPRINTF("ram_save_live: expected(%" PRIu64 ") <= max(" PRIu64 ")?\n",
> + expected_downtime, migrate_max_downtime());
>
> - DPRINTF("ram_save_live: expected(%" PRIu64 ") <= max(%" PRIu64 ")?\n",
> - expected_time, migrate_max_downtime());
> -
> - if (expected_time <= migrate_max_downtime()) {
> + if (expected_downtime <= migrate_max_downtime()) {
> memory_global_sync_dirty_bitmap(get_system_memory());
> - expected_time = ram_save_remaining() * TARGET_PAGE_SIZE / bwidth;
> + expected_downtime = ram_save_remaining() * TARGET_PAGE_SIZE / bwidth;
>
> - return expected_time <= migrate_max_downtime();
> + return expected_downtime <= migrate_max_downtime();
> }
> return 0;
> }
>
Reviewed-by: Orit Wasserman <address@hidden>
- [Qemu-devel] [PATCH 00/41] Migration cleanups, refactorings, stats, and more, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 02/41] fix migration sync, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 01/41] buffered_file: g_realloc() can't fail, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 05/41] migration: rename expected_time to expected_downtime, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 03/41] migration: store end_time in a local variable, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 04/41] migration: print total downtime for final phase of migration, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 08/41] savevm: Factorize ram globals reset in its own function, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 07/41] migration: print expected downtime in info migrate, Juan Quintela, 2012/09/21