qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/3] qapi: convert add_client


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 3/3] qapi: convert add_client
Date: Tue, 25 Sep 2012 16:04:15 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)

Luiz Capitulino <address@hidden> writes:

> On Tue, 25 Sep 2012 13:29:32 +0200
> Markus Armbruster <address@hidden> wrote:
>
>> Luiz Capitulino <address@hidden> writes:
>> 
>> > Also fixes a few issues while there:
>> >
>> >  1. The fd returned by monitor_get_fd() leaks in most error conditions
>> >  2. monitor_get_fd() return value is not checked. Best case we get
>> >     an error that is not correctly reported, worse case one of the
>> >     functions using the fd (with value of -1) will explode
>> >  3. A few error conditions aren't reported
>> 
>> 4. We now "use up" @fdname always.  Before, it was left alone for
>>    invalid @protocol.
>
> By "uses up" you mean that the fd will be consumed from the monitor's
> poll? I guess that's true for every command that accepts fds.

Yes, that's how these commands should work.  Before your patch,
add_graphics_client() doesn't call when protocol is invalid.  Your patch
fixes that.  Worth mentioning in the commit message.

[...]



reply via email to

[Prev in Thread] Current Thread [Next in Thread]