qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] target-xtensa: de-optimize EXTUI


From: Max Filippov
Subject: Re: [Qemu-devel] [PATCH] target-xtensa: de-optimize EXTUI
Date: Wed, 26 Sep 2012 03:05:18 +0400

On Wed, Sep 26, 2012 at 2:57 AM, Aurelien Jarno <address@hidden> wrote:
> Now that and with 0xff, 0xffff and 0xffffffff is optimized in
> tcg/tcg-op.h, there is no need to do it in target-xtensa/translate.c.
>
> Cc: Max Filippov <address@hidden>
> Signed-off-by: Aurelien Jarno <address@hidden>
> ---
>  target-xtensa/translate.c |   15 +--------------
>  1 file changed, 1 insertion(+), 14 deletions(-)
>
> diff --git a/target-xtensa/translate.c b/target-xtensa/translate.c
> index ba3ffcb..c1358ee 100644
> --- a/target-xtensa/translate.c
> +++ b/target-xtensa/translate.c
> @@ -1835,20 +1835,7 @@ static void disas_xtensa_insn(DisasContext *dc)
>                  } else {
>                      tcg_gen_mov_i32(tmp, cpu_R[RRR_T]);
>                  }

I guess shri above may be de-optimized as well.
In any case Acked-by: Max Filippov <address@hidden>

> -
> -                switch (maskimm) {
> -                case 0xff:
> -                    tcg_gen_ext8u_i32(cpu_R[RRR_R], tmp);
> -                    break;
> -
> -                case 0xffff:
> -                    tcg_gen_ext16u_i32(cpu_R[RRR_R], tmp);
> -                    break;
> -
> -                default:
> -                    tcg_gen_andi_i32(cpu_R[RRR_R], tmp, maskimm);
> -                    break;
> -                }
> +                tcg_gen_andi_i32(cpu_R[RRR_R], tmp, maskimm);
>                  tcg_temp_free(tmp);
>              }
>              break;
> --
> 1.7.10.4
>
>

-- 
Thanks.
-- Max



reply via email to

[Prev in Thread] Current Thread [Next in Thread]