Re: [Qemu-devel] [PATCH 0/2] add pci-serial device.

[Jan Kiszka]

On 2012-09-26 01:43, Anthony Liguori wrote:
> Gerd Hoffmann <address@hidden> writes:
> 
>>   Hi,
>>
>> Two patches, first split up serial.c a bit,
>> then actually add the pci-based serial device.
> 
> The series looks good to me.  A couple requests:
> 
> 1) Could you add a spec describing this new PCI device?  Doesn't need to
>    be more than a couple paragraphs since the device is super simple.
> 
> 2) Could you make the inf file an separate patch and either include
>    documentation in the commit message on how to use it with Windows or
>    just add a comment to the inf file?
> 
> This is a new PCI space for QEMU too.  Is this a driver that is "owned"
> by QEMU and Red Hat is donating the PCI id or is this a driver that RH
> controls that we're implementing?
> 
> The only reason I ask is whether this is something we can add new
> features to.  I can't think of one off hand, but it can't hurt to work
> this out up front.

Multiport e.g. (to save PCI slots). There was some proposal recently to
add a model of an real multiport PCI card, just don't find the mail
right now...

Jan

signature.asc
Description: OpenPGP digital signature