[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V3 1/5] libqblock build system
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH V3 1/5] libqblock build system |
Date: |
Thu, 27 Sep 2012 09:14:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
Il 27/09/2012 04:15, Wenchao Xia ha scritto:
> δΊ 2012-9-19 17:57, Paolo Bonzini ει:
>> Il 19/09/2012 08:35, Wenchao Xia ha scritto:
>>>>>
>>>>> +QEMU_OBJS=$(tools-obj-y) $(block-obj-y)
>>>>> +QEMU_OBJS_FILTERED=$(filter %.o,$(QEMU_OBJS))
>>>>
>>>> What does this filter out?
>>>>
>>> $(block-obj-y) contains /block, which would cause trouble in
>>> building,
>>> so filtered it out.
>>
>> I think that's because you have to call unnest-vars, not unnest-vars-1.
>>
>> Paolo
>>
> Tried with unnest-vars, it will create some unnessary directories in
> ./libqblock, unnest-vars-1 seems more reasonable.
Don't worry about unnecessary directories, worry about correctness.
Paolo
Re: [Qemu-devel] [PATCH V3 1/5] libqblock build system, Paolo Bonzini, 2012/09/18
[Qemu-devel] [PATCH V3 2/5] libqblock type defines, Wenchao Xia, 2012/09/18
[Qemu-devel] [PATCH V3 3/5] libqblock API, Wenchao Xia, 2012/09/18
[Qemu-devel] [PATCH V3 5/5] libqblock test example code, Wenchao Xia, 2012/09/18
[Qemu-devel] [PATCH V3 4/5] libqblock test build system, Wenchao Xia, 2012/09/18