[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V4 4/5] libqblock test build system
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH V4 4/5] libqblock test build system |
Date: |
Thu, 27 Sep 2012 10:30:07 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
Il 27/09/2012 04:24, Wenchao Xia ha scritto:
> +#libqblock
> +LIBQBLOCK_TEST_DIR=$(SRC_PATH)/tests/libqblock/test_images
> +qtest-lib-y=$(patsubst %.o, %.lo,$(qtest-obj-y))
I don't think you need qtest-obj-y for anything.
> +libqblock-la-path = $(libqblock-lib-path)/$(libqblock-lib-la)
> +
> +tests/libqblock/%.lo: QEMU_INCLUDES += -I$(libqblock-lib-path) -Itests
> +
> +check-libqblock-y = tests/libqblock/check-libqblock-qcow2$(EXESUF)
> +tests/libqblock/check-libqblock-qcow2$(EXESUF):
> tests/libqblock/libqblock-qcow2.lo $(libqblock-la-path) $(qtest-lib-y)
No need to use .lo here.
> + $(call quiet-command,$(LIBTOOL) --mode=link --quiet --tag=CC $(CC)
> -shared -rpath $(libdir) -o $@ $^," lt LINK $@")
> +
> +$(libqblock-la-path):
> + @echo "Building libqblock.la..."
> + $(call quiet-command,$(MAKE) -C $(SRC_PATH) $(libqblock-lib-la),)
No need for this.
> +$(LIBQBLOCK_TEST_DIR):
> + @echo "Make libqblock test directory"
> + mkdir $(LIBQBLOCK_TEST_DIR)
You can leave the files in tests/ directly, and avoid this as well.
> +check-libqblock: $(libqblock-la-path) $(LIBQBLOCK_TEST_DIR) $(patsubst
> %,check-%, $(check-libqblock-y))
Please add
check: check-libqblock
here, so that if libtool is present the check is run automatically.
Paolo
- [Qemu-devel] [PATCH V4 1/5] libqblock build system, (continued)
[Qemu-devel] [PATCH V4 4/5] libqblock test build system, Wenchao Xia, 2012/09/26
- Re: [Qemu-devel] [PATCH V4 4/5] libqblock test build system,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH V4 4/5] libqblock test build system, Wenchao Xia, 2012/09/27
- Re: [Qemu-devel] [PATCH V4 4/5] libqblock test build system, Paolo Bonzini, 2012/09/27
- Re: [Qemu-devel] [PATCH V4 4/5] libqblock test build system, Wenchao Xia, 2012/09/27
- Re: [Qemu-devel] [PATCH V4 4/5] libqblock test build system, Paolo Bonzini, 2012/09/28
- Re: [Qemu-devel] [PATCH V4 4/5] libqblock test build system, Wenchao Xia, 2012/09/28
[Qemu-devel] [PATCH V4 5/5] libqblock test example, Wenchao Xia, 2012/09/26
[Qemu-devel] [PATCH V4 3/5] libqblock API, Wenchao Xia, 2012/09/26