Re: [Qemu-devel] [PATCH 03/13] tcg: add temp_sync()

[Aurelien Jarno]

On Thu, Sep 27, 2012 at 11:30:14AM -0700, Richard Henderson wrote:
> On 09/27/2012 10:15 AM, Aurelien Jarno wrote:
> > Add a new function temp_sync() to synchronize the canonical location
> > of a temp with the value in the corresponding register, but without
> > freeing the associated register. Rewrite temp_save() to call
> > temp_sync() followed by temp_dead().
> > 
> > Signed-off-by: Aurelien Jarno <address@hidden>
> 
> Reviewed-by: Richard Henderson <address@hidden>
> 
> >          case TEMP_VAL_REG:
> > +            tcg_reg_sync(s, ts->reg);
> >              break;
> >          case TEMP_VAL_CONST:
> > +            ts->reg = tcg_reg_alloc(s, tcg_target_available_regs[ts->type],
> > +                                    allocated_regs);
> > +            ts->val_type = TEMP_VAL_REG;
> > +            s->reg_to_temp[ts->reg] = temp;
> > +            ts->mem_coherent = 0;
> > +            tcg_out_movi(s, ts->type, ts->reg, ts->val);
> > +            tcg_reg_sync(s, ts->reg);
> >              break;
> 
> Fallthru from TEMP_VAL_CONST into TEMP_VAL_REG?
> 

Good catch. It was refactoring from temp_save, and I didn't see it.


-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net