Re: [Qemu-devel] [PATCH RESEND 0/3] Introduce virtqueue_get_avail_bytes()

[Michael S. Tsirkin]

On Tue, Sep 25, 2012 at 12:05:13AM +0530, Amit Shah wrote:
> This is a rebased version of the patchset sent earlier.
> 
> The current virtqueue_avail_bytes() is a weird API: it's oddly-named:
> doesn't tell us what the API is going to do, and also suits just one
> use-case (that in virtio-net.c).
> 
> Introduce virtqueue_get_avail_bytes(), which returns the number of
> bytes in the vq available for input as well as output.
> virtqueue_avail_bytes() is made a wrapper around this new function for
> now.  It should be deprecated soon, though.
> 
> Doing this will also help with the virtio-rng patch where a
> VirtQueueElement is popped only to find out what its size is.  With
> this series applied, the popping (and the subsequent save/load of
> state for migration) isn't necessary.
> 
> The virtio-serial-bus code becomes better too, that's patch 3 here.
> 
> Please apply,

Applied, thanks.

> Amit Shah (3):
>   virtio: use unsigned int for counting bytes in vq
>   virtio: Introduce virtqueue_get_avail_bytes()
>   virtio-serial-bus: let chardev know the exact number of bytes
>     requested
> 
>  hw/virtio-serial-bus.c |   11 +++--------
>  hw/virtio.c            |   30 ++++++++++++++++++++++--------
>  hw/virtio.h            |    5 ++++-
>  3 files changed, 29 insertions(+), 17 deletions(-)
> 
> -- 
> 1.7.7.6