[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 09/45] block: rename block_job_complete to bl
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 09/45] block: rename block_job_complete to block_job_completed |
|
Date: |
Fri, 28 Sep 2012 13:00:53 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
Il 27/09/2012 22:31, Jeff Cody ha scritto:
>
> block_job_completed(): cleans up when a job is done
It also raises a BLOCK_JOB_COMPLETED event.
> block_job_complete(): requests that a block job be completed
>
> How about renaming both of them, respectively, to:
>
> block_job_cleanup(): cleans up when a job is done
> block_job_request_completion(): requests that a block job be completed
>
> I think that would remove any ambiguity.
I'll keep this patch for now, since it doesn't introduce any ambiguity yet.
I could rename block_job_complete to block_job_request_completion as you
suggested, but it would be inconsistent with the QMP command
block-job-complete, so there are downsides as well.
Paolo
- Re: [Qemu-devel] [PATCH v2 06/45] block: add support for job pause/resume, (continued)
[Qemu-devel] [PATCH v2 07/45] qmp: add block-job-pause and block-job-resume, Paolo Bonzini, 2012/09/26
[Qemu-devel] [PATCH v2 08/45] qemu-iotests: add test for pausing a streaming operation, Paolo Bonzini, 2012/09/26
[Qemu-devel] [PATCH v2 09/45] block: rename block_job_complete to block_job_completed, Paolo Bonzini, 2012/09/26
[Qemu-devel] [PATCH v2 11/45] iostatus: move BlockdevOnError declaration to QAPI, Paolo Bonzini, 2012/09/26
[Qemu-devel] [PATCH v2 13/45] iostatus: reorganize io error code, Paolo Bonzini, 2012/09/26
[Qemu-devel] [PATCH v2 10/45] iostatus: rename BlockErrorAction, BlockQMPEventAction, Paolo Bonzini, 2012/09/26
[Qemu-devel] [PATCH v2 12/45] iostatus: change is_read to a bool, Paolo Bonzini, 2012/09/26
[Qemu-devel] [PATCH v2 14/45] block: introduce block job error, Paolo Bonzini, 2012/09/26