Re: [Qemu-devel] [PATCH 136/147] softfloat: Implement uint64_to_float128

[Peter Maydell]

On 28 September 2012 02:13, Richard Henderson <address@hidden> wrote:
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  fpu/softfloat.c | 6 ++++++
>  fpu/softfloat.h | 1 +
>  2 files changed, 7 insertions(+)
>
> diff --git a/fpu/softfloat.c b/fpu/softfloat.c
> index 45f105a..8df3a32 100644
> --- a/fpu/softfloat.c
> +++ b/fpu/softfloat.c
> @@ -1337,6 +1337,12 @@ float128 int64_to_float128( int64 a STATUS_PARAM )
>
>  }
>
> +float128 uint64_to_float128( uint64 a STATUS_PARAM )
> +{
> +    if ( a == 0 ) return packFloat128( 0, 0, 0, 0 );

It would be more in line with the other float sizes to have
#define float128_zero make_float128(0, 0)
and then return float128_zero here.

> +    return normalizeRoundAndPackFloat128( 0, 0x406E, a, 0 STATUS_VAR );

(I assume you've tested at least enough to confirm that 0x406E
is the right number and not off by one one way or the other :-))

Incidentally personally I prefer to follow QEMU's spacing/bracing
style rather than the insane original-softfloat one, when
making changes. But the file is enough of a mess that I don't
care much one way or another, if you prefer to follow local
style.

-- PMM