Re: [Qemu-devel] [PATCH] fpu/softfloat.c: Return correctly signed values from uint64_to_float32

[Peter Maydell]

On 28 September 2012 16:17, Peter Maydell <address@hidden> wrote:
> The uint64_to_float32() conversion function was incorrectly always
> returning numbers with the sign bit set (ie negative numbers). Correct
> this so we return positive numbers instead.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> As far as I can see we use this function only in the three PPC SPE
> insns efscfuf, efsctsf, efsctuf. It is therefore untested(!); if
> anybody with PPC hw to test against could check the results of
> those functions that would be cool.

...incidentally in two of those uses we're operating on a constant:
 tmp = uint64_to_float64(1ULL << 32, &env->vec_status);
and it would probably be better to use make_float64() instead.

-- PMM