[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/9] qapi: add socket address types
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/9] qapi: add socket address types |
Date: |
Tue, 02 Oct 2012 17:31:00 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
Il 02/10/2012 17:27, Luiz Capitulino ha scritto:
>>> > > Wouldn't it be cleaner to pass a list of port numbers? We could have:
>>> > >
>>> > > *port-list: [ 'int' ]
>>> > > *service: 'str'
>> >
>> > A list of ports doesn't work too well for say 5900-5999. I think the
>> > port + count is the simplest.
> True, but consider making it a union then, so that we can have service
> as a string and port as an integer.
But then how would you name the containing union?
In the end this is a hack for VNC or little more... any change will
propagate all over the place due to QemuOpts and qemu-char using "to".
It is an optional argument, I don't think it's worth much time. :)
Paolo
- [Qemu-devel] [PATCH v2 0/9] Embedded NBD server, Paolo Bonzini, 2012/10/01
- [Qemu-devel] [PATCH v2 1/9] build: add QAPI files to the tools, Paolo Bonzini, 2012/10/01
- [Qemu-devel] [PATCH v2 2/9] qapi: add socket address types, Paolo Bonzini, 2012/10/01
- Re: [Qemu-devel] [PATCH v2 2/9] qapi: add socket address types, Eric Blake, 2012/10/01
- Re: [Qemu-devel] [PATCH v2 2/9] qapi: add socket address types, Paolo Bonzini, 2012/10/02
- Re: [Qemu-devel] [PATCH v2 2/9] qapi: add socket address types, Eric Blake, 2012/10/02
- Re: [Qemu-devel] [PATCH v2 2/9] qapi: add socket address types, Luiz Capitulino, 2012/10/02
- Re: [Qemu-devel] [PATCH v2 2/9] qapi: add socket address types, Paolo Bonzini, 2012/10/02
- Re: [Qemu-devel] [PATCH v2 2/9] qapi: add socket address types, Luiz Capitulino, 2012/10/02
- Re: [Qemu-devel] [PATCH v2 2/9] qapi: add socket address types,
Paolo Bonzini <=
Re: [Qemu-devel] [PATCH v2 2/9] qapi: add socket address types, Luiz Capitulino, 2012/10/02
[Qemu-devel] [PATCH v2 3/9] qemu-sockets: add error propagation to inet_parse, Paolo Bonzini, 2012/10/01
[Qemu-devel] [PATCH v2 4/9] qemu-sockets: add error propagation to Unix socket functions, Paolo Bonzini, 2012/10/01
[Qemu-devel] [PATCH v2 7/9] block: add close notifiers, Paolo Bonzini, 2012/10/01
[Qemu-devel] [PATCH v2 5/9] qemu-sockets: return IPSocketAddress from inet_parse, Paolo Bonzini, 2012/10/01