[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V5 5/5] libqblock test example
From: |
wenchao xia |
Subject: |
Re: [Qemu-devel] [PATCH V5 5/5] libqblock test example |
Date: |
Wed, 03 Oct 2012 19:31:18 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 5.1; rv:15.0) Gecko/20120907 Thunderbird/15.0.1 |
>> +const uint64_t *qb_get_virt_size(const QBlockStaticInfo *info)
>> +{
>> + return info->member_addr->virt_size;
>
>Please change this to:
>
> QBlockStaticInfoAddr addrs;
> qb_setup_info_addr(info, &addrs);
> return *addrs->virt_size;
>
>and similarly for the others.
>
>QBlockStaticInfoAddr should not be a public struct. I'm sorry if this
>wasn't clear.
>
>I'll review the rest on Monday.
>
>Paolo
>
Hi, QBlockStaticInfoAddr was declared as a pointer, user can't see
what it really is. It is actually defined in internal header files.
- Re: [Qemu-devel] [PATCH V5 5/5] libqblock test example,
wenchao xia <=