[Qemu-devel] O_DIRECT on glusterfs (was Re: [PATCH v9 4/4] block: Support GlusterFS as a QEMU block backend)

[Paolo Bonzini]

Il 24/09/2012 11:13, Bharata B Rao ha scritto:
> +
> +    if ((bdrv_flags & BDRV_O_NOCACHE)) {
> +        open_flags |= O_DIRECT;
> +    }
> +

If I understand correctly what I was told, this prevents the brick
server from using its own buffer cache.  This is quite different from
what we do for example over NFS (where the host does no caching, but
nothing prevents it on the remote server).

I think these 3 lines should be removed.  We're bypassing the host
buffer cache just by virtue of using a userspace driver, and that's what
cache=none cares about.

Paolo