[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] qemu-ga: use state dir from CONFIG_QEMUGA_S
From: |
Michael Roth |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] qemu-ga: use state dir from CONFIG_QEMUGA_STATEDIR |
Date: |
Wed, 3 Oct 2012 13:20:14 -0500 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Oct 03, 2012 at 02:24:19PM -0300, Luiz Capitulino wrote:
> Has the side effect of changing the default directory used to
> save the freeze status file from /tmp to /var/run.
>
> This is a beneficial change for two reasons:
>
> 1. FHS states that programs must not assume that files in /tmp will
> still exist between invocations of the program. This defeats
> the purpose of the freeze status file
>
> 2. FHS dictates that /var/run should be cleaned on boot, this
> automatically cleans up any stale file
>
> Signed-off-by: Luiz Capitulino <address@hidden>
Acked-by: Michael Roth <address@hidden>
> ---
> qemu-ga.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-ga.c b/qemu-ga.c
> index b747470..cbfd021 100644
> --- a/qemu-ga.c
> +++ b/qemu-ga.c
> @@ -40,8 +40,8 @@
> #else
> #define QGA_VIRTIO_PATH_DEFAULT "\\\\.\\Global\\org.qemu.guest_agent.0"
> #endif
> -#define QGA_PIDFILE_DEFAULT "/var/run/qemu-ga.pid"
> -#define QGA_STATEDIR_DEFAULT "/tmp"
> +#define QGA_PIDFILE_DEFAULT CONFIG_QEMUGA_STATEDIR "/qemu-ga.pid"
> +#define QGA_STATEDIR_DEFAULT CONFIG_QEMUGA_STATEDIR
> #define QGA_SENTINEL_BYTE 0xFF
>
> struct GAState {
> --
> 1.7.12.315.g682ce8b
>
>
[Qemu-devel] [PATCH 3/3] qemu-ga: use state dir from CONFIG_QEMUGA_STATEDIR, Luiz Capitulino, 2012/10/03
- Re: [Qemu-devel] [PATCH 3/3] qemu-ga: use state dir from CONFIG_QEMUGA_STATEDIR,
Michael Roth <=
[Qemu-devel] [PATCH 1/3] configure: guest_agent -> qemuga, Luiz Capitulino, 2012/10/03
Re: [Qemu-devel] [PATCH 0/3] qemu-ga: change default state dir to /var/run, Paolo Bonzini, 2012/10/03