[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v1 18/22] s390: avoid reaching into memory core in
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [RFC v1 18/22] s390: avoid reaching into memory core internals |
Date: |
Thu, 04 Oct 2012 10:12:46 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120912 Thunderbird/15.0.1 |
On 03/10/12 18:04, Avi Kivity wrote:
> use cpu_physical_memory_is_io() instead.
>
> Signed-off-by: Avi Kivity <address@hidden>
> ---
> target-s390x/misc_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-s390x/misc_helper.c b/target-s390x/misc_helper.c
> index e9b3cae..2da4c90 100644
> --- a/target-s390x/misc_helper.c
> +++ b/target-s390x/misc_helper.c
> @@ -81,7 +81,7 @@ int sclp_service_call(CPUS390XState *env, uint32_t sccb,
> uint64_t code)
> #endif
>
> /* basic checks */
> - if (!memory_region_is_ram(phys_page_find(sccb >> TARGET_PAGE_BITS)->mr))
> {
> + if (cpu_physical_memory_is_io(sccb)) {
> return -PGM_ADDRESSING;
> }
> if (sccb & ~0x7ffffff8ul) {
>
You can then probably also remove the #include "cputlb.h"
As a heads up: We have some patches pending that move that code.
see https://lists.gnu.org/archive/html/qemu-devel/2012-10/msg00121.html
So let us know if we should refresh the patch - otherwise we will let
that be resolved by the person that merges the commit. (will be a merge
conflict)
Christian
- Re: [Qemu-devel] [RFC v1 19/22] memory: per-AddressSpace dispatch, (continued)
[Qemu-devel] [RFC v1 17/22] memory: use AddressSpace for MemoryListener filtering, Avi Kivity, 2012/10/03
Re: [Qemu-devel] [RFC v1 17/22] memory: use AddressSpace for MemoryListener filtering, Anthony Liguori, 2012/10/04
[Qemu-devel] [RFC v1 18/22] s390: avoid reaching into memory core internals, Avi Kivity, 2012/10/03
- Re: [Qemu-devel] [RFC v1 18/22] s390: avoid reaching into memory core internals,
Christian Borntraeger <=
Re: [Qemu-devel] [RFC v1 00/22] Integrate DMA into the memory API, Blue Swirl, 2012/10/03
Re: [Qemu-devel] [RFC v1 00/22] Integrate DMA into the memory API, Avi Kivity, 2012/10/04
Re: [Qemu-devel] [RFC v1 00/22] Integrate DMA into the memory API, Paolo Bonzini, 2012/10/04