Re: [Qemu-devel] [PATCH] hw/arm_gic.c: Fix improper DPRINTF output.

[Evgeny Voevodin]

On 10/02/2012 07:50 AM, Evgeny Voevodin wrote:
> s->cpu_enabled is an array, so s->cpu_enabled ? "En" : "Dis" returns
> "En" always. We should use s->cpu_enabled[cpu] here.
>
> Signed-off-by: Evgeny Voevodin <address@hidden>
> ---
>   hw/arm_gic.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm_gic.c b/hw/arm_gic.c
> index 55871fa..4024dae 100644
> --- a/hw/arm_gic.c
> +++ b/hw/arm_gic.c
> @@ -566,7 +566,7 @@ static void gic_cpu_write(gic_state *s, int cpu, int 
> offset, uint32_t value)
>       switch (offset) {
>       case 0x00: /* Control */
>           s->cpu_enabled[cpu] = (value & 1);
> -        DPRINTF("CPU %d %sabled\n", cpu, s->cpu_enabled ? "En" : "Dis");
> +        DPRINTF("CPU %d %sabled\n", cpu, s->cpu_enabled[cpu] ? "En" : "Dis");
>           break;
>       case 0x04: /* Priority mask */
>           s->priority_mask[cpu] = (value & 0xff);

Did anybody pick this up?

--
Kind regards,
Evgeny Voevodin,
Technical Leader,
Mobile Group,
Samsung Moscow Research Center,
e-mail: address@hidden